feat: store server_info on ClientSession during initialization#2211
Open
shivama205 wants to merge 3 commits intomodelcontextprotocol:mainfrom
Open
feat: store server_info on ClientSession during initialization#2211shivama205 wants to merge 3 commits intomodelcontextprotocol:mainfrom
shivama205 wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
Store the server_info from InitializeResult on the session (alongside the already-stored server_capabilities) and expose it via get_server_info(), so callers no longer need to capture the return value of initialize() to access server metadata. Closes modelcontextprotocol#1018
Author
|
Friendly bump — this is a small change (stores server_info during initialize(), mirrors existing get_server_capabilities()). Would appreciate a review when someone gets a chance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server_infofromInitializeResultonClientSessionduringinitialize(), alongside the already-stored_server_capabilitiesget_server_info()method to access it after initialization (mirrors existingget_server_capabilities())initialize()to access server metadata like name/versionCloses #1018
Changes
src/mcp/client/session.py— added_server_infoattribute, stored duringinitialize(), exposed viaget_server_info()tests/client/test_session.py— addedtest_get_server_infoverifying None before init and correct value afterTest plan
ruff checkpassesruff formatpassespyrightpasses with 0 errors